-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: support eip-4844 #87
Comments
Yes, to support EIP-4844 we'd need support for blob transactions. Also, I don't think just adding the new transaction type is enough for Cancun support, there are also changes in execution and header for example. So it is a slightly larger change that is not a top priority for us right now. |
Exactly, the new blob tx also has a dynamic format for supporting kzg https://github.com/ethereum/go-ethereum/blob/2ab365f6d8c51d0e313d5ed30d777e49c7dd1213/core/types/tx_blob.go#L207 |
Alloy has already supported the 4844, |
Strong rec to move towards Alloy and we'll prioritize anything missing, Alloy is good to go on 4844 and has everything you need except some client side log queries. |
Alloy requires the MSRV 1.75 alloy-rs/alloy@main/Cargo.toml#L8, but the latest version of risc0's toolchain is only 1.70. |
Risc0's rustc has already supported the 1.75 by upgrade |
add missing config
Background
Holesky has released the Cankun fork, and supported the eip-4844, it added new transaction type(3), so zeth will panic when decode the new transaction from holesky
zeth/primitives/src/ethers.rs
Line 221 in 6867af4
FYI
EIP: https://eips.ethereum.org/EIPS/eip-4844
ethers-rs status
Related issues: gakonst/ethers-rs#1742, gakonst/ethers-rs#2719
Suggestion
By the way, reth has already supported the new EIP https://github.com/paradigmxyz/reth/blob/34216727d2994761ae6c756e899404f3b5eb312a/crates/primitives/src/transaction/eip4844.rs#L192, maybe zeth can move from ethers to reth
TODOs
The text was updated successfully, but these errors were encountered: