Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information of where branch jumping to in disassembler. #47

Merged
3 commits merged into from
Jul 21, 2020
Merged

Add information of where branch jumping to in disassembler. #47

3 commits merged into from
Jul 21, 2020

Conversation

luyahan
Copy link
Collaborator

@luyahan luyahan commented Jul 21, 2020 •
edited
Loading

Add information of where branch jumping to in disassembler. Such as:

0xf54d1a6630   230  05810113       addi      sp, sp, 88
0xf54d1a6634   234  6940006f       j         1684 -> 0xf54d1a6cc8  <+0x8c8>
                  -- B10 start --
0xf54d1a6638   238  fa810113       addi      sp, sp, -88

Help developer to debug.

@luyahan luyahan changed the title Add information of branch jumping to where. Add information of branch jumping to where in disassembler. Jul 21, 2020
@luyahan luyahan changed the title Add information of branch jumping to where in disassembler. Add information of where branch jumping to in disassembler. Jul 21, 2020
@luyahan luyahan force-pushed the add_information_disassemble branch 2 times, most recently from 5238f00 to 6d80031 Compare July 21, 2020 08:10
@penguinwu penguinwu self-requested a review July 21, 2020 14:00
@penguinwu
Copy link

@fw-brice I like the additional jump target information, but do you need to update analyzer.py to handle this new format?

@ghost
Copy link

ghost commented Jul 21, 2020

Yes, this is good, I will update the analyze tool in a separate branch after this one is merged.

ghost
ghost approved these changes Jul 21, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost mentioned this pull request Jul 21, 2020
Closed
@ghost ghost merged commit 12548c8 into riscv-collab:riscv-porting-dev Jul 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penguinwu penguinwu Awaiting requested review from penguinwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luyahan @penguinwu @obycode