Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #98 #101

Merged
merged 1 commit into from
May 9, 2024
Merged

Fixed issue #98 #101

merged 1 commit into from
May 9, 2024

Conversation

apazos
Copy link
Contributor

@apazos apazos commented May 9, 2024

Fixed the two issues reported in issue #98:

  1. For pseudo instructions that map to more than one real instruction, placed the real instructions on separate lines
  2. Added a footnote about 'myriad sequences' expression

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and also renders well in the browser.

@cmuellner cmuellner merged commit c1bad07 into riscv-non-isa:master May 9, 2024
@apazos apazos deleted the dev branch May 15, 2024 23:04
@kadiwa4
Copy link

kadiwa4 commented Jun 24, 2024

The footnote doesn't work :/

You forgot the colon after the definition of [^1], and also you should choose a different number because [^1] is already defined elsewhere

@apazos
Copy link
Contributor Author

apazos commented Jun 24, 2024

Thanks for testing and pointing it out, @kadiwa4 , will push a fix.

apazos added a commit to apazos/riscv-asm-manual that referenced this pull request Jun 24, 2024
@apazos
Copy link
Contributor Author

apazos commented Jun 24, 2024

I pushed the fix #103.
@kadiwa4, please let me know if you see any issue.
Thanks for pointing it out!

cmuellner pushed a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants