Remove R_RISCV_GNU_VTINHERIT and R_RISCV_GNU_VTENTRY #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All relocation types from 0 to 255 are either allocated or reserved in this psABI. I think we want to be consistent with it. |
They appeared to be copied from other ports while there is no assembly syntax for them. Just remove them like we remove R_RISCV_GPREL_[IS]. Fix riscv-non-isa#320
|
I think it's OK to return them back to "reserved" as these relocations have never been actually used. We need to actively remove declarations of these two relocations from GNU and LLVM toolchains, though. With that, LGTM, but please wait for other reviewers' responses. |
kito-cheng
approved these changes
Aug 8, 2022
saagarjha
pushed a commit
to ahjragaas/binutils-gdb
that referenced
this pull request
Aug 11, 2022
They were legacy relocation types copied from other ports. The related -fvtable-gc was removed from GCC in 2003. The associated assembler directives (.vtable_inherit and .vtable_entry) have never been supported by the RISC-V port. Remove related ld code. Link: riscv-non-isa/riscv-elf-psabi-doc#323
dogtopus
pushed a commit
to Project-Muteki/binutils-gdb
that referenced
this pull request
Aug 24, 2022
They were legacy relocation types copied from other ports. The related -fvtable-gc was removed from GCC in 2003. The associated assembler directives (.vtable_inherit and .vtable_entry) have never been supported by the RISC-V port. Remove related ld code. Link: riscv-non-isa/riscv-elf-psabi-doc#323
MaskRay
added a commit
to MaskRay/musl
that referenced
this pull request
Jan 26, 2024
Note:sSome relocation types were only used by binutils and accidentally exposed to previous versions of psABI (e.g. riscv-non-isa/riscv-elf-psabi-doc#205 riscv-non-isa/riscv-elf-psabi-doc#323). One of the value has been has been reused by GOT32_PCREL.
MaskRay
added a commit
to MaskRay/musl
that referenced
this pull request
Jan 26, 2024
Note: Some relocation types were only used by binutils and accidentally exposed to previous versions of psABI (e.g. riscv-non-isa/riscv-elf-psabi-doc#205 riscv-non-isa/riscv-elf-psabi-doc#323). One of the values has been reused by GOT32_PCREL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They appeared to be copied from other ports while there is no assembly syntax
for them. Just remove them like we remove R_RISCV_GPREL_[IS].
Fix #320