Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AR: Remove Message Registers. #878

Merged
merged 1 commit into from Sep 28, 2023
Merged

AR: Remove Message Registers. #878

merged 1 commit into from Sep 28, 2023

Conversation

timsifive
Copy link
Contributor

These were first introduced in #728.

Hopefully I got everything.

@timsifive timsifive marked this pull request as ready for review September 18, 2023 16:41
pdonahue-ventana
pdonahue-ventana reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug_register_printers.h deletion seems to be unrelated. Is that intentional?

@timsifive
AR: Remove Message Registers.
1aab674 
These were first introduced in #728.

Hopefully I got everything.
@timsifive
Copy link
Contributor Author

The debug_register_printers.h deletion seems to be unrelated. Is that intentional?

Good catch. Thanks.

pdonahue-ventana
pdonahue-ventana approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@timsifive timsifive merged commit ce016c6 into master Sep 28, 2023
1 check passed
@timsifive timsifive deleted the remove_mr branch September 28, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonahue-ventana pdonahue-ventana pdonahue-ventana approved these changes

Assignees
No one assigned
Labels
1.0 Backwards Incompatible Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timsifive @pdonahue-ventana