Old PR - Add initial value of Figure A.13 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kersten1
changed the title
Adding left over stuff from this PR - https://github.com/riscv/riscv-isa-manual/pull/529/files Signed-off-by: Kersten Richter <kersten@riscv.org>
aswaterman
force-pushed
the
kersten1-patch-2
branch
from
d1d90af
to
6662706
Compare
|
@daniellustig This is a zombie PR from 3.5 years ago that was never fully resolved. It seemed to have your general approval at the time, but can you double-check? Thanks! |
|
@daniellustig Can you take a look at this one? Trying to clear out old PRs. This was is originally from 2020 and needs another check from you please! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from old PR - https://github.com/riscv/riscv-isa-manual/pull/529/files
Note that some of these changes already made their way into the adoc file. So if these changes are not needed, close the PR.