Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Erroneous Attributes #1354

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Removal of Erroneous Attributes #1354

merged 1 commit into from
Apr 18, 2024

Conversation

sunshaoce
Copy link
Contributor

I noticed that this piece of formatting code was introduced in 15322920b281458a100a6375262d6516e8671a45, and then it looks very strange in unpriv-isa-asciidoc.html. I feel like it should be written incorrectly.

In https://github.com/riscv/riscv-isa-manual/releases/download/20240411-riscv-isa-release-DRAFT/unpriv-isa-asciidoc.html

The "Zam" extension, which permits misaligne%autowidth,float="center",align="center",d AMOs and specifies their semantics, has been defined.

@aswaterman aswaterman requested a review from wmat April 18, 2024 04:01
Copy link
Collaborator

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Those attributes are for a table, which this clearly is not. I must have mistakenly pasted them here.

@wmat wmat merged commit b337cbf into riscv:main Apr 18, 2024
1 of 2 checks passed
@sunshaoce sunshaoce deleted the fix branch April 18, 2024 14:48
wmat added a commit that referenced this pull request Apr 18, 2024
Deleted erroneously pasted text.  This was previously fixed by #1354 but for some
reason that fix broke the automated build of the spec.
ved-rivos pushed a commit to ved-rivos/riscv-isa-manual that referenced this pull request Jul 3, 2024
Deleted erroneously pasted text.  This was previously fixed by riscv#1354 but for some
reason that fix broke the automated build of the spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants