Fix running make -C build docker
#1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change I get the following error: `docker: Error response from daemon: create .: volume name is too short, names should be at least two alphanumeric characters.` After fixing that by using `pwd`, I get the following (the w flag is added due to `-C build`): `make: *** No rule to make target 'w'` Fix this by using -$(MAKEFLAGS). I confirmed that both `make -C build docker -j4` and `cd build && make docker -j4` work.
aswaterman
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change I get the following error:
docker: Error response from daemon: create .: volume name is too short, names should be at least two alphanumeric characters.After fixing that by using
pwd, I get the following (the w flag is added due to-C build):make: *** No rule to make target 'w'Fix this by using -$(MAKEFLAGS). I confirmed that bothmake -C build docker -j4andcd build && make docker -j4work.