Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump masks to C output #113

Merged
merged 2 commits into from
May 10, 2022
Merged

Dump masks to C output #113

merged 2 commits into from
May 10, 2022

Conversation

pavelkryukov
Copy link
Contributor

These masks may be used to write parsers

@aswaterman
Copy link
Member

I think ARG_LUT_ is not a great name prefix to put in an API. (For one, these are no longer lookup tables at this point.)

maybe something like RISCV_FIELD_? What do others think?

@neelgala
Copy link
Collaborator

RISCV_FIELDS_ or RISCV_ARGS_ is probably better

@pavelkryukov
Copy link
Contributor Author

Other macros don’t have RISCV_ prefix. Maybe INSN_FIELD_?

@neelgala
Copy link
Collaborator

INSN_FIELD_ sounds fine

@aswaterman aswaterman merged commit 9b9f61e into riscv:master May 10, 2022
@pavelkryukov pavelkryukov deleted the c-output branch May 11, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavelkryukov @aswaterman @neelgala