Test error inputs handling, fix few bugs #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 93.77% 95.35% +1.58%
==========================================
Files 2 3 +1
Lines 610 646 +36
==========================================
+ Hits 572 616 +44
+ Misses 38 30 -8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
pavelkryukov
changed the title
|
OK with you, @neelgala? |
|
Just a reminder. I have a follower patch to remove duplicate code (fields check and extraction should be a single operation) |
|
made one comment.. all else looks good.. sorry for the delay - thanks @pavelkryukov for all the work here :D |
|
@neelgala, sorry, don't see your comment. Have you submitted your review? |
parse.py
Outdated
| @@ -13,6 +13,11 @@ | |||
| pp = pprint.PrettyPrinter(indent=2) | |||
| logging.basicConfig(level=logging.INFO, format='%(levelname)s:: %(message)s') | |||
|
|
|||
| def parse_constant(string): | |||
| base = 16 if 'x' in string else 2 if 'b' in string else 10 | |||
There was a problem hiding this comment.
this entire function can just be return int(string,0) 0 automatically indicates python to select the base based on the string prefix
There was a problem hiding this comment.
@pavelkryukov here is my comment
No description provided.