feat(binder): support implicit type conversion in binary op #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangrunji0408
approved these changes
Jan 16, 2022
skyzh
reviewed
Jan 16, 2022
src/binder/expression/binary_op.rs
Outdated
| let right_physical_kind = right_data_type.physical_kind(); | ||
| if left_physical_kind != right_physical_kind { | ||
| match (left_physical_kind, right_physical_kind) { | ||
| ( |
There was a problem hiding this comment.
This pattern match seems... hard to read? I think it's better to return true / false for this match arm, and expand them in the match.
There was a problem hiding this comment.
Added comment for this not-equal check, which is used for filtering the case that need to do implicit casting. And the match here is used for deciding inserting BoundTypeCast to left expr or right expr.
skyzh
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #280