feat: support multi ordered primary key #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shmiwy <wyf000219@126.com>
skyzh
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Generally LGTM, good work!
For the bind_create_table part, I suggest to reorganize the code, so that it can be much clearer to readers.
- Firstly, get the pk constraints ident vec from
get_extra_pks, likevec!["a"] - Then, replace vec of ident to vec of column id, e.g.,
vec![ColumnId(1)]. May use hashmap in the process to accelerate lookups. We call thisordered_pks_from_constraint. - After that, iterate all columns, and generate a new set of
ordered_pks_from_columnsfromis_primaryproperty. - If both
ordered_pks_from_constraintandordered_pks_from_columnsare not empty, return error. Ifordered_pks_from_columnshas more than 1 elements, return error (if you want). - Then we can get the final
ordered_pksfrom eitherordered_pks_from_constraintorordered_pks_from_columns.
| @@ -124,10 +140,14 @@ mod tests { | |||
| let catalog = Arc::new(RootCatalog::new()); | |||
| let mut binder = Binder::new(catalog.clone()); | |||
| let sql = " | |||
| create table t1 (v1 int not null, v2 int); | |||
| create table t1 (v1 int not null, v2 int); | |||
There was a problem hiding this comment.
We can have planner test in the future 🤣 I guess writing this test case must be painful.
| table_name.clone(), | ||
| column_descs.to_vec(), | ||
| false, | ||
| ordered_pk_ids, |
There was a problem hiding this comment.
ordered_pk_ids also needs to be persisted to disk in manifest.rs CreateTableEntry. We can do this in later PRs.
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shmiwy wyf000219@126.com
try to implementation #625
at this moment, I just append
ordered_pk_idstotableCatalogwithoud usingis_primaryfiled inColumnDesc. It will make removingis_primaryin the future easier.