executor: use const generics to optimize hash join #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MingjiHan <mjhan@bu.edu>
Signed-off-by: MingjiHan <mjhan@bu.edu>
Signed-off-by: MingjiHan <mjhan@bu.edu>
Signed-off-by: MingjiHan <mjhan@bu.edu>
Signed-off-by: Mingji Han <mjhan@bu.edu>
MingjiHan99
force-pushed
the
hash_join_optimization
branch
from
8386f4c
to
92c37c0
Compare
xxchan
reviewed
Jan 7, 2023
xxchan
reviewed
Jan 8, 2023
Comment on lines
+269
to
+271
| if matches!(self.node(op), Expr::Inner) { | ||
| hash_join_operator!(self, JoinType::Inner, op, lkeys, rkeys, left, right) | ||
| } else if matches!(self.node(op), Expr::LeftOuter) { |
There was a problem hiding this comment.
Use match instead of if matches!? (It's surprising that there's no clippy warning? 🤔)
BTW just a personal preference not a requirement: I would define the macro just here, and catch local variables directly without passing arguments. 🤪
xxchan
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate hash join code in the compilation time to avoid testing join types during the execution for every row.