-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rw_catalog): make rw_worker_nodes list all nodes and resource #13487
Conversation
f1b335c
to
c55e0eb
Compare
c55e0eb
to
6682a0d
Compare
@@ -304,7 +305,7 @@ message UpdateWorkerNodeSchedulabilityResponse { | |||
} | |||
|
|||
message ListAllNodesRequest { | |||
common.WorkerType worker_type = 1; | |||
optional common.WorkerType worker_type = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is warned as a breaking change. But this RPC is only used by risectl and this PR, so it's fine.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13487 +/- ##
==========================================
+ Coverage 67.62% 67.67% +0.05%
==========================================
Files 1527 1527
Lines 260464 260542 +78
==========================================
+ Hits 176132 176319 +187
+ Misses 84332 84223 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please make it user-facing
and add some brief description.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR extends rw_catalog.rw_worker_nodes by
rw_version/total memory bytes/total cpu cores
, which is reported by worker node when it starts.started_at
, which is populated by meta node when a worker node starts.part of #12826
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
System catalog