Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SET TO DEFAULT #13693

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat: support SET TO DEFAULT #13693

merged 2 commits into from
Nov 29, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Nov 28, 2023

sI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

support SET TO DEFAULT for session config

#8851

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

We can set a session config parameter to default value by SET parameter_name TO DEFAULT

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also specify the release notes and tag the PR user-facing.

@st1page st1page added the user-facing-changes Contains changes that are visible to users label Nov 29, 2023
@st1page st1page added this pull request to the merge queue Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b196953) 68.31% compared to head (997812c) 68.32%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/frontend/src/session.rs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13693   +/-   ##
=======================================
  Coverage   68.31%   68.32%           
=======================================
  Files        1523     1523           
  Lines      261833   261804   -29     
=======================================
+ Hits       178878   178884    +6     
+ Misses      82955    82920   -35     
Flag Coverage Δ
rust 68.32% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@yuhao-su yuhao-su added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit ea49d4d Nov 29, 2023
26 of 27 checks passed
@yuhao-su yuhao-su deleted the yuhao/set_to_default branch November 29, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants