Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add description column for SHOW PARAMETERS #15113

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add description column to SHOW PARAMETERS. Use ParameterInfo to represent it to make it more consistent with session variables.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Member Author

BugenZhao commented Feb 18, 2024

@TennyZhuang TennyZhuang self-requested a review February 18, 2024 12:19
@BugenZhao BugenZhao changed the title feat(frontend): refine showing system parameters feat(frontend): add description column for SHOW PARAMETERS Feb 19, 2024
@BugenZhao BugenZhao marked this pull request as ready for review February 19, 2024 05:25
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 205a152 Feb 19, 2024
33 of 34 checks passed
@BugenZhao BugenZhao deleted the bz/refine-show-parameters branch February 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants