feat: add new option ignore_key for debeizum format
#15304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabVersion
commented
Feb 29, 2024
Comment on lines
+320
to
+322
| if source_schema.format == Format::Debezium { | ||
| try_consume_string_from_options(&mut format_encode_options_to_consume, DEBEZIUM_IGNORE_KEY); | ||
| } |
There was a problem hiding this comment.
@xiangjinwu I am not sure where to put this code, ignore_key seems the first format accepting options.
tabVersion
commented
Feb 29, 2024
Comment on lines
+52
to
+58
| pub fn from(props: &BTreeMap<String, String>) -> Self { | ||
| let ignore_key = props | ||
| .get(DEBEZIUM_IGNORE_KEY) | ||
| .map(|v| v.eq_ignore_ascii_case("true")) | ||
| .unwrap_or(false); | ||
| Self { ignore_key } | ||
| } |
There was a problem hiding this comment.
Also note that format_endcode_options are not tracked in with option checks (of course they are not in with clause).
I am wondering if we need another tool to track this options
| kafka.brokers = 'message_queue:29092', | ||
| kafka.scan.startup.mode = 'earliest') | ||
| FORMAT DEBEZIUM ENCODE JSON ( | ||
| ignore_key = 'true' |
There was a problem hiding this comment.
Is it possible to put this in the with statement? This may happen for debezium avro as well.
There was a problem hiding this comment.
It is an option for format rather than the connector, not suitable for putting it in with clause.
This may happen for debezium avro as well.
Yes, this option can also apply to debezium avro.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
resolve #15156 |
lmatz
pushed a commit
that referenced
this pull request
Mar 7, 2024
…5460) Signed-off-by: tabVersion <tabvision@bupt.icu>
2 tasks
1 task
xiangjinwu
changed the title
ignore_option for debeizum formatignore_key for debeizum format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add a format spec option
ignore_keyforformat DEBEZIUM. (acceptstrueandfalse, default tofalse)The option controls whether to ignore the key part for given messages. If set to true, debezium format will work with only the payload part.
Note that in this case, RW cannot handle tombstone message. So users should guarantee that payload MUST NOT be empty.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
as described above