fix(sink): add cassandra batch size and fix bigquery array null #15516
Conversation
xxhZs
force-pushed
the
xxh/fix-cassandra-max-batch-size
branch
from
64911ba
to
e10dad1
Compare
There was a problem hiding this comment.
Rest LGTM!
Please don't forget to update the "Documentation" + "Release Notes" sections in the PR description and add user-facing-change label for PR including user facing changes. Otherwise, the doc can become outdated.
Also, please link relevant issues to the PR.
| public CassandraConfig withMaxBatchRows(Integer maxBatchRows) { | ||
| if (maxBatchRows > 65536 || maxBatchRows < 1) { | ||
| throw new IllegalArgumentException( | ||
| "cassandra.max_batch_rows must be <= 65535 and >= 1"); |
There was a problem hiding this comment.
nits: better to include the maxBatchRows in the error message.
|
|
||
| public CassandraConfig withRequestTimeoutMs(Integer requestTimeoutMs) { | ||
| if (requestTimeoutMs < 1) { | ||
| throw new IllegalArgumentException("cassandra.request_timeout_ms must be >= 1"); |
There was a problem hiding this comment.
nits: better to include requestTimeoutMs in the error message.
| if let CustomJsonType::BigQuery = custom_json_type | ||
| && matches!(field.data_type(), DataType::List(_)) | ||
| { | ||
| return Ok(Value::Array(vec![])); |
There was a problem hiding this comment.
Can you include the BigQuery doc link as a comment here to explain why we need to do this?
| @@ -17,6 +17,10 @@ BigQueryConfig: | |||
| - name: bigquery.table | |||
| field_type: String | |||
| required: true | |||
| - name: bigquery.max_batch_rows | |||
There was a problem hiding this comment.
I just realized that with options for cassandra sink are not included in this yaml. Let's revisit other sinks as well to ensure all sinks are covered. We can merge this PR first.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
in this pr, we add bigquery's
max_batch_rowsand cassandra'smax_batch_rowsrequest_timeoutto fix problems of excessive data size.And we fix bigquery array null can't insert error,(the array null will be converted to []. )
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
In cassandra sink.Add two optional option.cassandra.max_batch_rows:Number of batch rows sent at a time defaults is 512,It should be less than 65535 according to cassandra, and ensures that the size of each batch(max_batch_rows * size of each row) is less than 50kb (Configuration items for cassandra: batch_size_fail_threshold_in_kb)
cassandra.request_timeout_ms:Waiting time for each batch, default is 2000msit not recommended to change, if you encounter timeout time is not enough, prioritize to reduce batch size
In bigquery sink,Add optional optionbigquery.max_batch_rows:Number of batch rows sent at a time defaults is 1024,Also due to this document, we will convert an array with a null value to an empty array
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types