feat(compaction): optimize compaction overlapping level #15736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Li0k
approved these changes
Mar 27, 2024
| }); | ||
| } | ||
| assert!(!groups.is_empty()); | ||
| groups.into_iter().map(|group| group.ssts).collect_vec() |
There was a problem hiding this comment.
IMO, we can add a warning log to determine the efficiency of the grouping algorithm. (If sst is all unordered, the grouping algorithm may fail, so that we can find problems faster).
question: What can we do if the grouping algorithm fails?
There was a problem hiding this comment.
I add a log info after calling this method
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
risingwavelabs:main
with commit Mar 28, 2024
390465c
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR try to solve the problem which RisingWave meet a large barrier and flush a lot of files in one overlapping-level. We must compact it in one simple task.
The merge iterator must seek all sstable and it could get the smallest key, it will create a lot of pending read IO. This operation will always cause our task fail.
TODO:
we shall also refactor the timeout and retry strategy of compaction iterator
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.