fix(catalog): grant view when grant table #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
force-pushed
the
wkx/fix-grant-priviilege-on-all-table
branch
from
2f75f68
to
70b783f
Compare
yezizp2012
approved these changes
May 11, 2024
There was a problem hiding this comment.
The single node e2e test failed, rest LGTM:
thread 'rw-main' panicked at /risingwave/src/meta/src/controller/utils.rs:762:38:
internal error: entered unreachable code: index is not supported yet
stack backtrace:
0: rust_begin_unwind
at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/std/src/panicking.rs:645:5
xxhZs
approved these changes
May 11, 2024
KeXiangWang
force-pushed
the
wkx/fix-grant-priviilege-on-all-table
branch
3 times, most recently
from
6b4fdbf
to
dce9ee9
Compare
KeXiangWang
force-pushed
the
wkx/fix-grant-priviilege-on-all-table
branch
from
dce9ee9
to
c66f771
Compare
KeXiangWang
added a commit
that referenced
this pull request
May 16, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Allow
grant/revokeprivileges on views.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.