Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix s3 streaming upload metrics #16929

Merged
merged 5 commits into from
May 25, 2024
Merged

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented May 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Do not use MonitoredStreamingUploader when the object store is s3 and it is not opendal. Otherwise, the streaming upload ops is wrong.
  • Fix the s3 cost metrics by excluding DELETE op because it is free.
  • Enable retry and timeout when streaming upload falls back to upload in S3StreamingUploader.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested a review from Li0k May 24, 2024 10:38
@github-actions github-actions bot added the type/fix Bug fix label May 24, 2024
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@hzxa21 hzxa21 added this pull request to the merge queue May 25, 2024
Merged via the queue into main with commit 7a3fd21 May 25, 2024
27 of 28 checks passed
@hzxa21 hzxa21 deleted the patrick/fix-streaming-upload-metrics branch May 25, 2024 14:14
Li0k pushed a commit that referenced this pull request Jul 24, 2024
Li0k pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants