Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): sqlsmith test filepath #8183

Merged
merged 8 commits into from
Feb 27, 2023
Merged

fix(ci): sqlsmith test filepath #8183

merged 8 commits into from
Feb 27, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 25, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Enable sqlsmith deterministic test on main-cron.
  • Pre-generate more queries (up to 100). This is required by cron (since its test num is 100).

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label Feb 25, 2023
@TennyZhuang
Copy link
Contributor

I've submitted an empty commit while debugging the buildkite service, please ignore that. Thanks :)

@kwannoel kwannoel requested a review from lmatz February 27, 2023 01:36
@kwannoel kwannoel requested a review from lmatz February 27, 2023 01:53
@kwannoel
Copy link
Contributor Author

Large diff due to pre-generated sqlsmith test files. We have 100 of them now.

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 27, 2023

If we increase past that, will move these into a separate repository / zip the files?

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #8183 (8822094) into main (7f237d7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8183      +/-   ##
==========================================
- Coverage   71.85%   71.84%   -0.01%     
==========================================
  Files        1129     1129              
  Lines      181263   181263              
==========================================
- Hits       130239   130224      -15     
- Misses      51024    51039      +15     
Flag Coverage Δ
rust 71.84% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
...torage/src/hummock/local_version/pinned_version.rs 88.75% <0.00%> (-0.63%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (-0.52%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.25% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel added this pull request to the merge queue Feb 27, 2023
@lmatz
Copy link
Contributor

lmatz commented Feb 27, 2023

If we increase past that, will move these into a separate repository / zip the files?

That will be better, i.e. doing both I guess. If it’s only useful for CI, not even need to be public

Merged via the queue into main with commit 9d0418b Feb 27, 2023
@kwannoel kwannoel deleted the kwannoel/fix-fuzz-ci branch February 27, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants