Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Transpose #1219

Merged
merged 10 commits into from
Dec 8, 2019
Merged

Conversation

earboxer
Copy link
Contributor

@earboxer earboxer commented Dec 6, 2019

Based on code and discussion from #1189.

@lpugin
Copy link
Contributor

lpugin commented Dec 6, 2019

Could you make the PR to develop-transpose for now? Also, there is an error with AppVeyor. Any thoughts?

@earboxer earboxer changed the base branch from develop to develop-transpose December 6, 2019 13:44
@earboxer
Copy link
Contributor Author

earboxer commented Dec 6, 2019

@lpugin I changed it to target develop-transpose, and also added #include <cctype>, which should allow isdigit to work.

Do we need to change appveyor.yml so that it runs on develop-transpose?

@craigsapp
Copy link
Contributor

Should I CamelCase the functions in the Transpose class? Perhaps not necessary since the class is not directly related to MEI functionality?

@lpugin
Copy link
Contributor

lpugin commented Dec 8, 2019

Should I CamelCase the functions in the Transpose class? Perhaps not necessary since the class is not directly related to MEI functionality?

Yes please. (This is a Verovio coding guideline)

@lpugin lpugin merged commit 91d2454 into rism-digital:develop-transpose Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants