Generalise fallback to default file #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function get_marc_editor_profile_path in app/models/config_file_path.rb to wrap all open file calls with RISM::MARC or RISM::EDITOR_CONFIGURATION configuration values, so that when a specific file does not exist, fall back to default paths.
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are uses RISM::MARC and RISM::EDITOR_CONFIGURATION all over Muscat, and if a value other than default is defined, the application fails in unsuspected places.
This patch creates a generic function so it falls back to default if a specific file does not exist. I have been using for a while in two different Muscat test instances, one having the default values and another having created a custom value.