Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove square brackets from key signature facet values #299

Closed
ahankinson opened this issue May 17, 2024 · 0 comments
Closed

Remove square brackets from key signature facet values #299

ahankinson opened this issue May 17, 2024 · 0 comments
Assignees
Labels
Component: Incipit Search Issues that affect the incipit search Type: Enhancement New features or improvements

Comments

@ahankinson
Copy link
Contributor

The supplied values in the key signatures mean that key signatures that are the same are split across many different values. To find all the incipits that are in Ab, the user needs to select all of these:

  • b[B]EAD
  • bBEAD
  • bBEA[D]
  • bBE[AD]
  • bB[E]AD
  • b[B]EA[D]
  • bB[EAD]
  • bBE[A]D

For the purposes of the facet, we should remove all the square brackets in the key signature, so that users have only one value to select, instead of 8!

@ahankinson ahankinson added Priority: High Type: Enhancement New features or improvements Component: Incipit Search Issues that affect the incipit search labels May 17, 2024
@ahankinson ahankinson self-assigned this May 17, 2024
ahankinson added a commit to rism-digital/muscatplus_server that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Incipit Search Issues that affect the incipit search Type: Enhancement New features or improvements
Projects
None yet
Development

No branches or pull requests

1 participant