docs: add missing docs from new modules #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
commented
Jan 22, 2024
| @@ -372,5 +372,5 @@ func Module() *object.Module { | |||
| "get": object.NewBuiltin("k8s.get", Get), | |||
| "apply": object.NewBuiltin("k8s.apply", Apply), | |||
| "delete": object.NewBuiltin("k8s.delete", Delete), | |||
| }).WithDocstring(docs) | |||
There was a problem hiding this comment.
WithDocstring doesn't seem to be defined anywhere and I don't know where it came from.
There was a problem hiding this comment.
Yeah, thanks for cleaning this up. It must've been a lingering merge/rebase issue from my docs branch.
luisdavim
commented
Jan 22, 2024
| @@ -1,3 +1,3 @@ | |||
| module github.com/risor-io/risor/cmd/risor-docs | |||
|
|
|||
| go 1.21.4 | |||
| go 1.21 | |||
There was a problem hiding this comment.
For some reason, and even though I always run the latest version, gopls fails when the version number includes the patch version and there's a replace statement in go.mod, there are some reports of this issue upstream but it hasn't been fixed yet, so if you don't mind, I'm dropping the patch version here.
Signed-off-by: Luis Davim <dluis@vmware.com>
luisdavim
force-pushed
the
missing_docs
branch
from
f954074
to
5f85034
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.