Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case with compiling loops containing undefined variables #240

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

myzie
Copy link
Collaborator

@myzie myzie commented Apr 28, 2024

Capture the code the loop is associated with so we can correctly close it out, when there is a compile error.

@myzie myzie linked an issue Apr 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 32.99%. Comparing base (ebc2522) to head (0eed241).
Report is 1 commits behind head on main.

Files Patch % Lines
object/set.go 41.66% 7 Missing ⚠️
compiler/compiler.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   32.82%   32.99%   +0.16%     
==========================================
  Files         129      129              
  Lines       16013    16025      +12     
==========================================
+ Hits         5257     5288      +31     
+ Misses      10124    10111      -13     
+ Partials      632      626       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myzie myzie merged commit b5bcb67 into main Apr 28, 2024
5 checks passed
@myzie myzie deleted the 236-compiler-panics-while-accessing-undefined-variable branch April 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler panics while accessing undefined variable
1 participant