Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for IRC action handler functionality #378

Open
Tjzabel opened this issue Aug 18, 2021 · 0 comments
Open

Create unit tests for IRC action handler functionality #378

Tjzabel opened this issue Aug 18, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Anyone is welcome to help us with this! IRC Issues relating to the IRC bridge quality assurance CI tests, unit tests, integration tests, any kind of testing
Milestone

Comments

@Tjzabel
Copy link
Member

Tjzabel commented Aug 18, 2021

Summary

IRC messages can also contain actions (/me). We currently do not have unit tests for this functionality.

Background

Is your improvement related to a problem? Please describe:

Not related to a direct problem.

Describe the solution you'd like:

Unit testing needs to cover various ACTION commands to make sure everything works smoothly.

Describe alternatives you've considered:

No other alternatives.

Details

The girc library makes use of an isAction function to see if a given message contains an action (i.e. /me). We need to figure out the best way to mock an action and test for it.

Outcome

IRC actions are fully tested.

@Tjzabel Tjzabel added help wanted Anyone is welcome to help us with this! good first issue Good for newcomers quality assurance CI tests, unit tests, integration tests, any kind of testing IRC Issues relating to the IRC bridge labels Aug 18, 2021
@Tjzabel Tjzabel added this to the v2.x.x milestone Aug 18, 2021
@Tjzabel Tjzabel changed the title Create unit tests for IRC action handler functionailty Create unit tests for IRC action handler functionality Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Anyone is welcome to help us with this! IRC Issues relating to the IRC bridge quality assurance CI tests, unit tests, integration tests, any kind of testing
Projects
None yet
Development

No branches or pull requests

1 participant