Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the flashing of scrollbar on window resize #256

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

hierror
Copy link
Contributor

@hierror hierror commented Feb 4, 2021

Followed the recommendations in the SimpleBar repository's issues and fixed the blinking scrollbar glitch. The CSS rule that caused the bug was the overflow: auto , but since display: flex had no impact on the layout, I've removed it aswell.

@vercel
Copy link

vercel bot commented Feb 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ritz078/moose/gyg9g7xcp
✅ Preview: https://moose-git-fork-hierror-bugfix-glitch-simplebar.ritz078.now.sh

@ritz078
Copy link
Owner

ritz078 commented Feb 5, 2021

I will have a look by EOD.

@ritz078 ritz078 changed the title bugfix: Removed the conflicting/buggy CSS affecting SimpleBar component fixed the flashing of scrollbar on window resize Feb 6, 2021
Copy link
Owner

@ritz078 ritz078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hierror Great job. This works well.

Thank you for your contribution 🎉

@ritz078
Copy link
Owner

ritz078 commented Feb 6, 2021

@all-contributors please add @hierror for code.

@allcontributors
Copy link
Contributor

@ritz078

I've put up a pull request to add @hierror! 🎉

@ritz078 ritz078 merged commit 0e5ccf8 into ritz078:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants