Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router.Helpers now needs to be explicitly aliased as Routes #65

Closed
x-ji opened this issue Jul 8, 2018 · 8 comments
Closed

Router.Helpers now needs to be explicitly aliased as Routes #65

x-ji opened this issue Jul 8, 2018 · 8 comments

Comments

@x-ji
Copy link

x-ji commented Jul 8, 2018

See phoenixframework/phoenix@928cc6a and phoenixframework/phoenix#2530

When I tried mix phauxth.new, code such as user_path are generated in views, while it should really be Routes.user_path now, after this change in Phoenix.

I'm not sure if this is already addressed in version 2.0 of phauxth. A quick search doesn't seem to find any related issue, so I opened this.

@riverrun
Copy link
Owner

riverrun commented Sep 2, 2018

Thanks for opening the issue. I'll look into it soon.

@riverrun
Copy link
Owner

riverrun commented Sep 2, 2018

Do you know what version this was added?

@x-ji
Copy link
Author

x-ji commented Sep 2, 2018

The changes are still in the master branch and I think in 1.4.0-dev, therefore they are not part of the current 1.3.x versions yet. Guess they'll go into effect when 1.4.0 is officially released. I just noticed them since I created a new project with 1.4.0-dev to test the built-in Webpack integration.

@x-ji
Copy link
Author

x-ji commented Sep 2, 2018

Also see phoenixframework/phoenix#2955

@riverrun
Copy link
Owner

riverrun commented Sep 2, 2018

Thanks. I noticed that they are not in the default installer, so I'm now looking at what the dev installer is producing and updating accordingly.

@riverrun
Copy link
Owner

riverrun commented Sep 2, 2018

I have just made some updates to the example app - using the assets folder generated from the dev installer, but I haven't added the Routes alias yet. I want to look into it further and then add it.

@riverrun
Copy link
Owner

riverrun commented Oct 8, 2018

I want to wait until Phoenix 1.4 comes out before adding the Routes alias - hopefully, that will be quite soon.

@riverrun
Copy link
Owner

Version 2.0.0 has these changes in the example app - once Phoenix 1.4 and Phauxth 2.0.0 are released, I will update the installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants