fix: actor runners by name query #3100
Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
Graphite Automations"Test" took an action on this PR • (10/07/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Merge activity
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| gcTime: 5000, | ||
| queryKey: ["actor", actorId, "database", table], | ||
| queryKey: [hash, "actor", actorId, "database", table], | ||
| queryFn: async ({ queryKey: [, actorId, , table] }) => { |
There was a problem hiding this comment.
The query key destructuring pattern doesn't account for the hash parameter that was added to the query key array. The current pattern [, actorId, , table] will extract incorrect values since the actual array structure is now [hash, "actor", actorId, "database", table]. This should be updated to [, , actorId, , table] to properly extract the values from their new positions in the array.
| queryFn: async ({ queryKey: [, actorId, , table] }) => { | |
| queryFn: async ({ queryKey: [, , actorId, , table] }) => { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
| }) => { | ||
| const def = createDefaultActorContext(); | ||
| const def = createDefaultActorContext({ | ||
| hash: btoa(url + inspectorToken + (engineToken || "")).slice(0, 8), |
There was a problem hiding this comment.
There appears to be a variable name mismatch in the hash calculation. The function parameters include token, but the hash calculation uses inspectorToken which isn't defined in the scope. This should be updated to use token instead:
hash: btoa(url + token + (engineToken || "")).slice(0, 8),This will ensure the hash is calculated using the correct parameter values.
| hash: btoa(url + inspectorToken + (engineToken || "")).slice(0, 8), | |
| hash: btoa(url + token + (engineToken || "")).slice(0, 8), |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
### TL;DR Added Sentry tunnel configuration and improved actor list UI layout. ### What changed? - Added a `tunnel` property to the Sentry configuration in both the HTML template and TypeScript interfaces - Initialized Sentry with the tunnel configuration from the app config - Simplified the `runnerByNameQueryOptions` function by removing the redundant namespace parameter - Enhanced the actors list UI by: - Adding flex layout with centered items to the actor information container - Adding proper spacing between datacenter information and other elements - Ensuring consistent margin for the datacenter display regardless of content ### How to test? 1. Verify that Sentry initialization works with the new tunnel configuration by setting the `VITE_APP_SENTRY_TUNNEL` environment variable 2. Check that the actors list displays correctly with proper spacing between elements 3. Confirm that runner queries still work correctly with the simplified namespace handling ### Why make this change? The Sentry tunnel configuration allows for proxy routing of error reports, which can be useful in environments with strict CSP policies or when direct access to Sentry servers is restricted. The UI improvements to the actors list enhance readability by providing better spacing and alignment of actor information elements.
2 participants
TL;DR
Added Sentry tunnel configuration and improved actor list UI layout.
What changed?
tunnelproperty to the Sentry configuration in both the HTML template and TypeScript interfacesrunnerByNameQueryOptionsfunction by removing the redundant namespace parameterHow to test?
VITE_APP_SENTRY_TUNNELenvironment variableWhy make this change?
The Sentry tunnel configuration allows for proxy routing of error reports, which can be useful in environments with strict CSP policies or when direct access to Sentry servers is restricted. The UI improvements to the actors list enhance readability by providing better spacing and alignment of actor information elements.