fix: inspector #3104
Closed
fix: inspector #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
NathanFlurry
approved these changes
Oct 7, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
### TL;DR Fixed query key indexing in actor queries context and added default timestamp-based hash generation. ### What changed? - Fixed the `queryFn` implementations to correctly access the `actorId` from the query key array at index 2 instead of index 1 - Added a default value for the `hash` parameter that uses the current timestamp (`Date.now()`) when no hash is provided ### How to test? 1. Verify that actor queries work correctly by navigating to the actor inspector in the UI 2. Test with both explicit hash values and without providing a hash to ensure the default timestamp-based hash works properly 3. Confirm that all actor-related queries (ping, state, connections, database, events, RPCs, auto-wake-up) function as expected ### Why make this change? The previous implementation had incorrect indexing when accessing query key elements, which could lead to undefined values and errors. The query key structure is `[hash, "actor", actorId, ...]`, so the `actorId` is at index 2, not index 1. Additionally, providing a default timestamp-based hash ensures that the context always has a unique identifier even when not explicitly provided.
Graphite Automations"Test" took an action on this PR • (10/07/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed query key indexing in actor queries context and added default timestamp-based hash generation.
What changed?
queryFnimplementations to correctly access theactorIdfrom the query key array at index 2 instead of index 1hashparameter that uses the current timestamp (Date.now()) when no hash is providedHow to test?
Why make this change?
The previous implementation had incorrect indexing when accessing query key elements, which could lead to undefined values and errors. The query key structure is
[hash, "actor", actorId, ...], so theactorIdis at index 2, not index 1. Additionally, providing a default timestamp-based hash ensures that the context always has a unique identifier even when not explicitly provided.