feat: add server logs endpoint #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AngelOnFira and the rest of your teammates on |
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
5538ee2
to
6e3621c
Compare
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
6e3621c
to
ca4a40f
Compare
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
ca4a40f
to
dd6a7c5
Compare
AngelOnFira
commented
Jul 25, 2024
| @@ -28,6 +28,7 @@ fn main() -> anyhow::Result<()> { | |||
| let root_user_enabled = std::env::var("NOMAD_META_root_user_enabled") | |||
| .context("NOMAD_META_root_user_enabled")? | |||
| == "1"; | |||
| let runner = std::env::var("NOMAD_META_runner").unwrap_or("job_run".to_string()); | |||
There was a problem hiding this comment.
This should work for any existing usage of job-runner, while the new dynamic servers passes in a new var.
AngelOnFira
commented
Jul 25, 2024
Comment on lines
+75
to
+78
| // let server_data = unwrap!(server_get_res.servers.first()); | ||
| // let server_game_id = unwrap_ref!(server_data.game_id).as_uuid(); | ||
|
|
||
| // ensure_eq!(game_id, server_game_id, "server does not belong to game"); |
There was a problem hiding this comment.
This isn't correct rn, fixing all auth upstack after this is merged
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
dd6a7c5
to
71fb1aa
Compare
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
71fb1aa
to
337558a
Compare
MasterPtato
previously requested changes
Jul 27, 2024
fern/definition/servers/logs.yml
Outdated
| auth: true | ||
| base-path: /servers | ||
| endpoints: | ||
| listBuilds: |
There was a problem hiding this comment.
Should this be called listBuilds?
| @@ -0,0 +1,89 @@ | |||
| // use chirp_worker::prelude::*; | |||
There was a problem hiding this comment.
Should these tests be reimplemented?
There was a problem hiding this comment.
i'm going to get as much as i can up to speed soon
NathanFlurry
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
337558a
to
7a57f54
Compare
This was referenced Jul 31, 2024
Merged
AngelOnFira
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
3 times, most recently
from
94895ba
to
6c9d6a2
Compare
NathanFlurry
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
6c9d6a2
to
d0a77f3
Compare
This was referenced Aug 7, 2024
Merge activity
|
This will close RVTEE-313, RVTEE-310, RVTEE-163, RVTEE-311, RVTEE-308, RVTEE-307, RVTEE-306
NathanFlurry
force-pushed
the
07-23-feat_add_server_logs_endpoint
branch
from
d0a77f3
to
a23073b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close RVTEE-313, RVTEE-310, RVTEE-163, RVTEE-311, RVTEE-308, RVTEE-307, RVTEE-306