Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve breaking change to S3 client #130

Merged

Conversation

rahulmadnawat
Copy link
Collaborator

@rahulmadnawat rahulmadnawat commented Nov 29, 2023

Changes

Resolves a breaking change to the AWS Go SDK's S3 client.

aws/aws-sdk-go-v2#2162

Tests

  • make test passing
  • relevant integration tests passing

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (d823a37) 73.03% compared to head (7e4a175) 73.69%.
Report is 49 commits behind head on main.

Files Patch % Lines
schema.go 62.70% 54 Missing and 15 partials ⚠️
delta.go 85.98% 25 Missing and 12 partials ⚠️
tablestate.go 82.75% 3 Missing and 2 partials ⚠️
ondiskstate.go 95.08% 2 Missing and 1 partial ⚠️
storage/s3store/s3store.go 86.36% 2 Missing and 1 partial ⚠️
storage/filestore/filestore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   73.03%   73.69%   +0.66%     
==========================================
  Files          18       18              
  Lines        3556     3737     +181     
==========================================
+ Hits         2597     2754     +157     
- Misses        701      708       +7     
- Partials      258      275      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulmadnawat rahulmadnawat merged commit 741298e into rivian:main Nov 29, 2023
4 checks passed
@rahulmadnawat rahulmadnawat deleted the resolve-s3-client-breaking-change branch November 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants