Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metainfo file to the installation #3346

Merged
merged 1 commit into from
May 29, 2024
Merged

Added metainfo file to the installation #3346

merged 1 commit into from
May 29, 2024

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented May 22, 2024

Your checklist for this pull request

Detailed description

  • Added metainfo file to the installation because it is required by most modern Linux package managers and Flatpak.
  • Switched from hardcoded directory name to CMAKE_INSTALL_DATAROOTDIR use.
  • Removed the COMPONENT option from the desktop file installation entry since the file is not a development file and is always needed.
  • Added missing GenericName and Comment to the desktop file.

Test plan (required)

Run the build and installation on any UNIX operating system. The desktop and metainfo files should be installed.

Closing issues

n/a

@karliss karliss self-requested a review May 22, 2024 10:47
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ret2libc take a look please

@karliss
Copy link
Member

karliss commented May 23, 2024

The generic name and comment in .desktop file feels somewhat redundant.

image

Just browsed my /usr/share/applications folder to see how it gets used in practice

a) A lot of programs didn't bother with generic name.
b) For software that have both the generic name and comment. Generic name is often a noun, but comment starts with verbs. It somewhat matches the example in .desktop file spec.

So my suggestion is doing one of the following:

  • getting rid of GenericName
  • replace the FOSS part in comment with a more useful information like "Reverse engineering platform based on rizin". Most of the software that you run on Linux is open source, so mentioning it in the context of .desktop isn't much of a selling point.
  • in commnet use a sentence with verbs something like "Disassemble, analyze and debug executable files for various architectures."

Does anyone have an example of a desktop environment displaying the "GenericName" or "Comment" values anywhere. At least on Gnome the application menu didn't seem to use it, and more detailed view in software center was based on appdata.xml not the .desktop file content. I am not saying that it's useless, I am just curios how various desktop environments use this information.

Copy link
Member

@karliss karliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the .appimage from CI, and all 3 files were installed in the expected folders.

@xvitaly
Copy link
Contributor Author

xvitaly commented May 23, 2024

getting rid of GenericName

GenericName is heavily used by KDE Plasma. Without it, the second line of the application launcher is empty and it looks ugly.

Does anyone have an example of a desktop environment displaying the "GenericName" or "Comment" values anywhere.

image

The first line - Name.
The second line - GenericName.
Tooltip - Comment.

the application menu didn't seem to use it, and more detailed view in software center was based on appdata.xml not the .desktop file content

Appdata is only used by package managers. Application launchers use only desktop files.

replace the FOSS part in comment with a more useful information like "Reverse engineering platform based on rizin".

Done.

Switched from hardcoded directory name to CMAKE_INSTALL_DATAROOTDIR
use.

Removed the COMPONENT option from the desktop file installation
entry since the file is not a development file and is always needed.

Added missing GenericName and Comment to the desktop file.
@karliss karliss merged commit 38c683b into rizinorg:dev May 29, 2024
9 checks passed
@xvitaly xvitaly deleted the fix-shortcut branch May 29, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants