-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metainfo file to the installation #3346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ret2libc take a look please
The generic name and comment in .desktop file feels somewhat redundant. Just browsed my /usr/share/applications folder to see how it gets used in practice a) A lot of programs didn't bother with generic name. So my suggestion is doing one of the following:
Does anyone have an example of a desktop environment displaying the "GenericName" or "Comment" values anywhere. At least on Gnome the application menu didn't seem to use it, and more detailed view in software center was based on appdata.xml not the .desktop file content. I am not saying that it's useless, I am just curios how various desktop environments use this information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the .appimage from CI, and all 3 files were installed in the expected folders.
GenericName is heavily used by KDE Plasma. Without it, the second line of the application launcher is empty and it looks ugly.
The first line - Name.
Appdata is only used by package managers. Application launchers use only desktop files.
Done. |
Switched from hardcoded directory name to CMAKE_INSTALL_DATAROOTDIR use. Removed the COMPONENT option from the desktop file installation entry since the file is not a development file and is always needed. Added missing GenericName and Comment to the desktop file.
Your checklist for this pull request
Detailed description
CMAKE_INSTALL_DATAROOTDIR
use.COMPONENT
option from the desktop file installation entry since the file is not a development file and is always needed.GenericName
andComment
to the desktop file.Test plan (required)
Run the build and installation on any UNIX operating system. The desktop and metainfo files should be installed.
Closing issues
n/a