Update Jaguar GPU to Rizin

[officialcjunior]

Update Jaguar GPU to Rizin.
Just renamed the r2 data structures to its Rizin equivalent, preserving the logic, in an effort to learn about plugins.

It builds and gets installed. Haven't really tested it, yet.

$ make
cc -g -fPIC -I/usr/local/include/librz -I/usr/local/include/librz/sdb    -c -o jaguar-gpu.o jaguar-gpu.c
cc -g -fPIC -I/usr/local/include/librz -I/usr/local/include/librz/sdb  -shared -L/usr/local/lib -lrz_asm -lrz_parse -lrz_cons -lrz_reg -lrz_flag -lrz_bin -lrz_magic -lrz_io -lrz_syscall -lrz_socket -lrz_util  jaguar-gpu.o -o jaguar-gpu.so

$ rz-asm -L | grep -i jag
_d__  32         jaguar-gpu  LGPL3   Disassembler for the Jaguar GPU (by Sebastien Alaiwan)

[XVilka]

I recommend to just remove the Makefile and use Meson build, like keystone plugin: https://github.com/rizinorg/rizin-extras/blob/master/keystone/meson.build

[officialcjunior]

I have added the meson.build, which works, but I had put the plugin path manually, which is a bit clumsy. Let me know if that needs to/can be changed.

[XVilka]

I think @ret2libc is more qualified for this question.

[ret2libc]

Yeah this is something we need to figure out... I think probably all plugins should have a meson_options.txt which allows to specify the plugins_directory, but for now I think you can use ~/.local/share/rizin/plugins.

I'll try to think about these problems soon as i switch back to rz-pm.

[XVilka]

I think @ret2libc is more qualified for this question.

[XVilka]

You can probably fold these functions in some kind of macros to reduce the same pattern again and again.

[XVilka]

Please use endian functions from RzUtil.

[officialcjunior]

Could you be a bit more specific on where to look for them?

[ret2libc]

rz_endian.h

[officialcjunior]

Regarding that, I tried using rz_read_be16() but doesn't seem to work.
I think, it's maybe because there's a (*b) += 2; over here on this one.

Do you have a pointer to get around this problem?

[ret2libc]

https://www.geeksforgeeks.org/double-pointer-pointer-pointer-c/

[officialcjunior]

Thank you!
Please take a look now. Worked fine with my test file locally.

Also, I was first motivated to do the same increment on case 38 where read16BE was used, I didn't catch any difference in the disassembly after adding that.
Now, I am slightly confused why.

[officialcjunior]

Managed to find a bin to test it. I think it's working as it should.

$ rizin  Arkanna\ Demo\ \(PD\).bin 
[0x00000000]> e asm.arch=jaguar-gpu
[0x00000000]> pd 10
            0x00000000      neg       r28
            0x00000002      add       r0, r7
            0x00000004      add       r0, r7
            0x00000006      add       r7, r16
            0x00000008      neg       r12
            0x0000000a      not       r28
            0x0000000c      invalid
            0x0000000e      add       r7, r16
            0x00000010      add       r2, r14
            0x00000012      resmac  r25