Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from RzList to RzPVector in RzBinPlugin #3775

Closed
15 of 16 tasks
XVilka opened this issue Aug 21, 2023 · 2 comments · Fixed by #4118
Closed
15 of 16 tasks

Switch from RzList to RzPVector in RzBinPlugin #3775

XVilka opened this issue Aug 21, 2023 · 2 comments · Fixed by #4118
Labels
Milestone

Comments

@XVilka
Copy link
Member

XVilka commented Aug 21, 2023

Currently it uses a lot of RzList which is slower to traverse and takes more memory. The idea is to substitute them for RzPVector instead.
These are members that could be switched:

  • RzList /*<RzBinImport *>*/ *(*imports)(RzBinFile *bf);
  • RzList /*<RzBinSymbol *>*/ *(*symbols)(RzBinFile *bf);
  • RzList /*<RzBinString *>*/ *(*strings)(RzBinFile *bf);
  • RzList /*<RzBinVirtualFile *>*/ *(*virtual_files)(RzBinFile *bf);
  • RzList /*<RzBinMap *>*/ *(*maps)(RzBinFile *bf);
  • RzList /*<RzBinAddr *>*/ *(*entries)(RzBinFile *bf);
  • RzList /*<RzBinSection *>*/ *(*sections)(RzBinFile *bf);
  • RzList /*<RzBinField *>*/ *(*fields)(RzBinFile *bf);
  • RzList /*<char *>*/ *(*libs)(RzBinFile *bf);
  • RzList /*<RzBinReloc *>*/ *(*relocs)(RzBinFile *bf);
  • RzList /*<RzBinTrycatch *>*/ *(*trycatch)(RzBinFile *bf);
  • RzList /*<RzBinClass *>*/ *(*classes)(RzBinFile *bf);
  • RzList /*<RzBinMem *>*/ *(*mem)(RzBinFile *bf);
  • RzList /*<RzBinReloc *>*/ *(*patch_relocs)(RzBinFile *bf);
  • RzList /*<RzBinFileHash *>*/ *(*hashes)(RzBinFile *bf);
  • RzList /*<RzBinResource *>*/ *(*resources)(RzBinFile *bf);
@XVilka
Copy link
Member Author

XVilka commented Oct 13, 2023

@PeiweiHu hi, do you plan to continue working on this?

@PeiweiHu
Copy link
Contributor

PeiweiHu commented Nov 2, 2023

@PeiweiHu hi, do you plan to continue working on this?

I just came across this message since the last month was too busy. I will continue working on this and also other stuffs these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants