Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pdc pseudo-decompiler #105

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Remove pdc pseudo-decompiler #105

merged 1 commit into from
Nov 27, 2020

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 27, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (ACTUALLY REMOVED)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Remove pdc pseudo decompiler since it does a terrible job and we have 3 external decompilers - rz-ghidra, rz-dec and retdec.

Test plan

All green

Closing issues

Closes #89

@thestr4ng3r thestr4ng3r merged commit d4c077c into dev Nov 27, 2020
@thestr4ng3r thestr4ng3r deleted the remove-pdc branch November 27, 2020 09:12
@FortStatement FortStatement mentioned this pull request Feb 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pdc
2 participants
@XVilka @thestr4ng3r