Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tef test #1310

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Update tef test #1310

merged 1 commit into from
Jul 15, 2021

Conversation

Basstorm
Copy link
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

The calculation of the hash index is hash % ht.size, so the index will change when the size changes. This may cause the order of output could be different on different OS/Arch because the types stored in the SDB are different.

Test plan

...

Closing issues

...

@XVilka
Copy link
Member

XVilka commented Jul 15, 2021

Could you please make a test instead that uses grep? For example,

  • tef 4~? to count the number of output
  • tef4~FOO.BAR to check the exact member

@Basstorm Basstorm changed the title Mark the tef test as broken Update tef test Jul 15, 2021
@XVilka XVilka merged commit 1814ee8 into rizinorg:rztypes Jul 15, 2021
@Basstorm Basstorm deleted the mark_tef_broken branch July 15, 2021 06:05
XVilka pushed a commit that referenced this pull request Jul 15, 2021
@Basstorm @XVilka
Update tef test (#1310)
928347f
XVilka pushed a commit that referenced this pull request Jul 15, 2021
@Basstorm @XVilka
Update tef test (#1310)
6c334c1
XVilka pushed a commit that referenced this pull request Jul 16, 2021
@Basstorm @XVilka
Update tef test (#1310)
3537a71
XVilka pushed a commit that referenced this pull request Jul 19, 2021
@Basstorm @XVilka
Update tef test (#1310)
702c488
thestr4ng3r pushed a commit that referenced this pull request Jul 19, 2021
@Basstorm @thestr4ng3r
Update tef test (#1310)
df2c869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy

@ret2libc ret2libc Awaiting requested review from ret2libc

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r

@wargio wargio Awaiting requested review from wargio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Basstorm @XVilka