-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized argument value detected by clang CI #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
February 19, 2021 15:36
ghost
requested review from
kazarmy,
ret2libc,
thestr4ng3r,
wargio,
XVilka and
yossizap
as code owners
February 19, 2021 15:36
wargio
approved these changes
Feb 19, 2021
|
ret2libc
reviewed
Feb 20, 2021
yossizap
reviewed
Feb 20, 2021
Codecov Report
@@ Coverage Diff @@
## dev #661 +/- ##
==========================================
- Coverage 42.79% 42.78% -0.02%
==========================================
Files 869 869
Lines 316347 316346 -1
==========================================
- Hits 135382 135334 -48
- Misses 180965 181012 +47
Continue to review full report at Codecov.
|
ret2libc
approved these changes
Feb 21, 2021
ghost
deleted the
fix_uninitialized_argument_value
branch
June 17, 2021 12:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
The gdb code is really strange. I don't understand how it worked.I fixed the warning when I prevent the token processing if j != 4.
PS: Should we move shlr/gdb and shlr/tcc to subprojects?
Test plan
...
Closing issues
...