-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translation for zh_CN and zh_TW #4739
Conversation
needs some proofreading... |
@alvinhochun Would you please check whether these look natural to you? Thanks. |
c9f90cd
to
01e60e9
Compare
Mind if I invite the folks over at l10n-tw to help? |
Of course I don't mind. |
|
5bce8fe
to
3ee0a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed traditional chinese.
language/np3_zh_tw/lexer_zh_tw.rc
Outdated
IDS_LEX_2ND_CH_MODIFIED "第二變更記錄標記:已儲存" | ||
IDS_LEX_2ND_CH_SAVED "第二變更記錄標記:已修改" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這兩個翻譯是否放反?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感謝。稍後我會修復一下。
46ef902
to
5bcf5f5
Compare
Closes rizonesoft#4698. Signed-off-by: LIU Hao <lh_mouse@126.com>
Thank you! |
Hello @lhmouse , |
Thank you. |
In my opinion, since Notepad3 is a Windows-only application, the translations should try to follow the terminology Microsoft uses. (Though there may be some exceptions.) They can be looked up on https://www.microsoft.com/en-us/language. Some specific change suggestions and comments for zh_TW:
復原 in zh_TW UI usually refers to "undo". I suggest 還原 to avoid confusion. |
Yes I totally agree with that. Would you mind opening a PR for these changes? There are probably more issues, not specific to this file.
I am not sure which one you use daily. The choice of zh_CN was obviously influenced by the original meaning of script i.e. 劇本. I'm fine with this change.
These look good to me.
Yes. These in Markdown match Strong and emphasis in HTML, which by convention are rendered as bold and italic, respectively. I thought about this a little, and decided that we had better not effect more confusion. The first sentence above is actually Yes. These in Markdown match <strong>Strong</strong> and <em>emphasis</em> in
HTML, which by convention are rendered as <b>bold</b> and <i>italic</i>, respectively.
I had to look at source code to figure out what on earth it meant. Sadly there wasn't any comment about it, and I saw ScintillaOrg/lexilla#117. This is one of the many bad examples about localization - a phrase is given without contextual information.
These look good to me, too.
Maybe it's better to change them all:
|
I am not up to do a full review of the translation now. Would you mind applying the changes for me? If not I can probably make a PR this weekend.
The CommonMark Markdown reference uses "italic" and "bold" and I thought that is less ambiguous. The spec does say "emphasis" and "strong emphasis" though. If we stick to this, then 強調 for "emphasis" is fine, but neither 加粗 nor 粗體 seem appropriate for "strong" as they would be inconsistent. I don't have a good suggestion. |
My recommendation is that we do a full review and submit a commit that will address all such issues, maybe later. There's no hurry.
I am afraid there is no official translation for strong. Use of Footnotes |
This include updates proposed in rizonesoft#4739.
Closes #4698.