Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bump allocator in Sender #65

Merged
merged 5 commits into from
May 19, 2024
Merged

Expose bump allocator in Sender #65

merged 5 commits into from
May 19, 2024

Conversation

rj00a
Copy link
Owner

@rj00a rj00a commented May 19, 2024

This PR removes the 'static requirement from Sender::send and Sender::send_to and exposes the bump allocator by providing allocation methods on Sender. Sender is now entirely internally mutable (takes &self on all the methods).

This partially addresses #44 but is missing a few things.

  • Doesn't allow received events with borrowed data to pass though Sender::send without a clone because Receiver and Sender have different lifetimes. Might still need a combined Sender and Receiver type.
  • Can't use the bump allocator from a &mut World.
  • No optional collections module. I think it would be easier to just add an unstable feature for the unstable allocator api for those who need it.

@rj00a rj00a merged commit d21420b into main May 19, 2024
6 checks passed
@rj00a rj00a deleted the expose_bump_allocator branch May 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant