Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overrides of SimplePanel.AddAll call refresh outside of a singleRender wrapper. #511

Closed
wagyourtail opened this issue Feb 6, 2024 · 1 comment
Closed

overrides of SimplePanel.AddAll call refresh outside of a singleRender wrapper. #511

wagyourtail opened this issue Feb 6, 2024 · 1 comment

Comments

@wagyourtail
Copy link
Contributor

wagyourtail commented Feb 6, 2024 •
edited
Loading

Several components,

the ones I checked being: FlexPanel, DockPanel, ResponsiveGridPanel.
use children.forEach { this.add(it) } as their implementation of addAll, which ends up calling reRender multiple times.

this is bad for performance.
@wagyourtail wagyourtail changed the title overrides of SimplePanel.AddAll call refresh outside of a singleRender wrapper. overrides of SimplePanel.AddAll call refresh outside of a singleRender wrapper. Feb 6, 2024
rjaros added a commit that referenced this issue Feb 13, 2024
@rjaros
Optimize addAll with singleRender wrapper (#511)
474d0fe
@rjaros
Copy link
Owner

rjaros commented Feb 13, 2024

Fixed in 7.4.0

@rjaros rjaros closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjaros @wagyourtail