Dist::Zilla::Role::PPI: lack of filename

[van-de-bugger]

ppi_document_for_file creates a PPI document is such a way:

my $encoded_content = $file->encoded_content;
...
my $document = PPI::Document->new(\$encoded_content);

Since PPI document is created from string, it does not know its filename. It makes creating error messages hardly possible.

I have requested PP to accept filename argument, so Dist::Zilla can pass filename to the constructor:

my $document = PPI::Document->new(\$encoded_content, filename => $file->name);

Meanwhile, Dist::Zilla can pass filename through file content by using #line directive:

$encoded_content = "#line 1 " . $file->name . "\n" . $encoded_content;
my $document = PPI::Document->new(\$encoded_content);

Later, if PPI implements filename argument, Dist::Zilla can utilize it, keeping #line directive as a backup:

if ( PPI::Document->VERSION() >= XXX ) {
    $document = PPI::Document->new(\$encoded_content, filename => $file->name);
} else {
    $encoded_content = "#line 1 " . $file->name . "\n" . $encoded_content;
    $document = PPI::Document->new(\$encoded_content);
};

[rjbs]

I'd rather wait for PPI to have a facility for this. Adding #line means removing it later, and I'm just a bit concerned about other artifacts that may occur due to this change.