Commits on Aug 30, 2018

1. FSEvents: fix bug where rewatching path fails across channels …

   The following code reproduces a bug where if you watch a parent
   and child directory across multiple channels and then call
   notify.Stop() on the either channel, any subsequent calls to
   notify.Watch() on a grandparent directory will fail:
   
   ```go
   package main
   
   import (
   	"fmt"
   	"io/ioutil"
   	"os"
   
   	"github.com/rjeczalik/notify"
   )
   
   func watch(path string) chan notify.EventInfo {
   	c := make(chan notify.EventInfo, 1)
   	if err := notify.Watch(path+"...", c, notify.All); err != nil {
   		panic(err)
   	}
   	return c
   }
   
   func main() {
   	os.MkdirAll("./a/b/c", 0775)
   	defer os.RemoveAll("./a")
   
   	// watch a child and parent path across multiple channels.
   	// this can happen in any order.
   	ch1 := watch("./a/b/c")
   	ch2 := watch("./a/b")
   
   	// unwatch ./a/b -- this is what causes the panic on the next line.
   	// note that this also fails if we notify.Stop(ch1) instead.
   	notify.Stop(ch2)
   
   	// watching ./a will now return errNotWatched.
   	ch3 := watch("./a")
   
   	// just a test to make sure watching still works when we get here.
   	go func() { ioutil.WriteFile("a/b/c/d", []byte("X"), 0664) }()
   	fmt.Println(<-ch1, <-ch3)
   }
   ```
   
   Fortunately we can fix this failure by simply not returning
   errNotWatched from unwatch(), which simply performs a no-op
   if there is no active stream for the path when Unwatch() is
   called.

   

   lsegal committed Aug 30, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for c69266d
   • Browse repository at this point

   Copy the full SHA

   c69266d View commit details

   Browse the repository at this point in the history