Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab stop for Add button + #365

Closed
2 tasks done
kav opened this issue Oct 28, 2016 · 5 comments
Closed
2 tasks done

Tab stop for Add button + #365

kav opened this issue Oct 28, 2016 · 5 comments

Comments

@kav
Copy link

kav commented Oct 28, 2016

Prerequisites

  • I have read the documentation;
  • In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

When tabbing through a form that contains array schema the cursor does not stop on the plus button.

Also happy to PR this on a thumbs up

Expected behavior

I'd expect the + button to take focus and probably click on spacebar

Actual behavior

It doesn't

Version

0.40.0

@kav
Copy link
Author

kav commented Nov 1, 2016

It makes sense not to tab to reorder and remove but add is a very common when filling out a form.

@glasserc
Copy link
Contributor

glasserc commented Nov 2, 2016

This sounds good to me, although @n1k0 is the final judge!

@n1k0
Copy link
Collaborator

n1k0 commented Nov 2, 2016

Sounds good to me too. Would you want to work on a patch?

@kav
Copy link
Author

kav commented Nov 3, 2016

Sure thing. The trivial fix of removing the tabstop leaves our tab ever so slightly poorly placed on the + button after adding an item. I'll look into a sane solution to that. The ref chasing solution that seems to be common in react land feels terrible but a bit of tabstop number tracking and setting it correctly for the plus after add might do the trick.

@n1k0 n1k0 closed this as completed in c87b377 Nov 12, 2016
n1k0 added a commit that referenced this issue Nov 25, 2016
* Update dependencies to their latest versions. (#386)
* Fix #385: Avoid dynamic requires. (#387)
* Fix #365: Tab stop for Add button + (#392)
* Add a single field form example in the playground (#390)
* Allow using field names containing a dot character (#397)
* Updated eslint config.
* Improve checkbox and radio button styles (#403)
* Add missing proptype for disabled (#416)
* Temporary fix for #349 and facebook/react#7630 radio widget bug (#423)
@n1k0
Copy link
Collaborator

n1k0 commented Nov 25, 2016

Released along v0.41.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants