Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab stop for Add button + #392

Merged
merged 1 commit into from Nov 12, 2016
Merged

Tab stop for Add button + #392

merged 1 commit into from Nov 12, 2016

Conversation

eeinowski
Copy link
Contributor

Reasons for making this change

This makes it possible to add an array item while tabbing through a form.

#365

@n1k0
Copy link
Collaborator

n1k0 commented Nov 12, 2016

Yes of course!

@n1k0 n1k0 merged commit c87b377 into rjsf-team:master Nov 12, 2016
n1k0 added a commit that referenced this pull request Nov 25, 2016
* Update dependencies to their latest versions. (#386)
* Fix #385: Avoid dynamic requires. (#387)
* Fix #365: Tab stop for Add button + (#392)
* Add a single field form example in the playground (#390)
* Allow using field names containing a dot character (#397)
* Updated eslint config.
* Improve checkbox and radio button styles (#403)
* Add missing proptype for disabled (#416)
* Temporary fix for #349 and facebook/react#7630 radio widget bug (#423)
@n1k0
Copy link
Collaborator

n1k0 commented Nov 25, 2016

Released along v0.41.2.

@olzraiti
Copy link
Contributor

olzraiti commented Nov 30, 2016

How about we make all array field buttons tabbable? Delete and order buttons have explicitly tabIndex set to -1. I don't see why a user shouldn't be able to delete/order an item while tabbing if he/she can add an item while tabbing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants