Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.41.0 introduced some issues in Meteor #385

Closed
dulguun0225 opened this issue Nov 9, 2016 · 1 comment
Closed

0.41.0 introduced some issues in Meteor #385

dulguun0225 opened this issue Nov 9, 2016 · 1 comment

Comments

@dulguun0225
Copy link

meteor/meteor#8035

Dynamic require calls like this one (where the module identifier string is not a string literal) are not supported in client-bundled code, because it's hard/impossible to know at bundling time exactly what module is being imported.

Webpack works around this by including all modules matching a certain configuration option, but then you're potentially shipping unused modules to the client.

You can force certain specific modules to be included in the bundle by putting

require("react-jsonschema-form/lib/components/fields/SchemaField.js")
explicitly in your own code. Repeat for any other modules that might be imported by dynamic require calls at runtime.

The code in question appears to have been added two days ago, so I think this error was introduced by the release of react-jsonschema-form@0.40.0, not by the recent Meteor release.
@dulguun0225 dulguun0225 changed the title 0.40.0 introduced some issues in Meteor 0.41.0 introduced some issues in Meteor Nov 9, 2016
n1k0 added a commit that referenced this issue Nov 10, 2016
@n1k0
Fix #385: Avoid dynamic requires.
d1bf931
@n1k0 n1k0 mentioned this issue Nov 10, 2016
Merged
@glasserc glasserc mentioned this issue Nov 10, 2016
Closed
@n1k0 n1k0 closed this as completed in 1ff1549 Nov 11, 2016
n1k0 added a commit that referenced this issue Nov 25, 2016
@n1k0
Bump v0.41.2.
d14369b 
* Update dependencies to their latest versions. (#386)
* Fix #385: Avoid dynamic requires. (#387)
* Fix #365: Tab stop for Add button + (#392)
* Add a single field form example in the playground (#390)
* Allow using field names containing a dot character (#397)
* Updated eslint config.
* Improve checkbox and radio button styles (#403)
* Add missing proptype for disabled (#416)
* Temporary fix for #349 and facebook/react#7630 radio widget bug (#423)
@n1k0
Copy link
Collaborator

n1k0 commented Nov 25, 2016

Released along v0.41.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n1k0 @dulguun0225