Level up clarity in README; (closes #22) #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rjz
reviewed
Nov 11, 2016
|
|
||
| it('should get a restricted page', function (done) { | ||
| testSession.get('/restricted') | ||
| authenticatedSession.get('/restricted') |
There was a problem hiding this comment.
I think this still leaves us in a broken state, though, as authenticatedSession isn't available here. But we can:
- Move this test inside the
'after authenticating'spec - Define
var authenticatedSessionin the top level of the spec
There was a problem hiding this comment.
Yipes, you're spot on
|
Updated. Happy to change more, too -- any spacing or verbiage concerns? |
|
Nope—it's a beauty. Thanks, @aaronik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clarity to README in the form of fixing a small semantic error