Remove buoy #7
Merged
Remove buoy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbernier
approved these changes
Apr 3, 2019
src/canal.erl
Outdated
| @@ -338,16 +315,15 @@ handle_read_response( | |||
|
|
|||
| State2 = del_request(RequestId, State), | |||
| gen_server:reply(From, Ret), | |||
| {noreply, State2}. | |||
| {noreply, del_request(RequestId, State2)}. | |||
There was a problem hiding this comment.
What is the purpose of this new del_request ?
There was a problem hiding this comment.
I didn't see 2 lines up. State2 has the request deleted.
rkallos
force-pushed
the
upkeep/remove-buoy
branch
from
75f3956
to
aea8eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces buoy with httpc from the Erlang standard library.
In our current production environment, connections to Vault are closed after 1 minute. This would occasionally leave canal in a state where it would not be able to issue requests to Vault until the connection is reestablished. With httpc, new connections are opened with each request, and to my knowledge, don't last beyond the lifetime of the request. I expect this will fix the problem.